Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2548 Add warning for suspicious message #2626

Merged
merged 12 commits into from
Nov 4, 2024
Merged

#2548 Add warning for suspicious message #2626

merged 12 commits into from
Nov 4, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 27, 2024 •
edited by sosnovsky
Loading

This PR added warning for suspicious message

close #2548 // if this PR closes an issue

Tests (delete all except exactly one):

  • Tests added or updated

image

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

@sosnovsky XCode 16 image is not available in a1-standard-4 machine so had to change it to a2-standard-4
But it has 2 concurrency running limit.
Do we have to increase this limit for a2-standard-4 machine?

image

@sosnovsky
Copy link
Collaborator

Probably this limit is set by Semaphore CI, as I don't see settings section for changing these machine limits.
But 2 machines running limit should be ok, as all jobs will still be executed, one-by-one.

Also I noticed that build time decreased from 30 minutes on previous machine type to 8 minutes on a2-standard-4, then we can just merge 4 test jobs into 2, if they'll run faster too.

And let's also add fail_fast configuration to semaphore.yml like at https://github.com/FlowCrypt/flowcrypt-ios/blob/79651582a739faa3e21cc233ae99c15126385bf3/.semaphore/semaphore.yml#L12-14 (it'll stop other jobs executions after first test failure):

fail_fast:
  stop:
    when: branch != 'master'

@ioanmo226 ioanmo226 marked this pull request as ready for review September 30, 2024 04:28
@ioanmo226
Copy link
Collaborator Author

Will fix XCode 16 image issue in new issue at #2627

sosnovsky
sosnovsky reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

FlowCryptUI/Cell Nodes/SecurityWarningNode.swift Outdated Show resolved Hide resolved
appium/tests/specs/mock/inbox/CheckSecurityWarningForSuspiciousEmail.spec.ts Outdated Show resolved Hide resolved
sosnovsky
sosnovsky approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@sosnovsky sosnovsky merged commit e2bce84 into master Nov 4, 2024
12 checks passed
@sosnovsky sosnovsky deleted the 2548-add-warning-for-suspicious-messages branch November 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning for suspicious messages
2 participants
@ioanmo226 @sosnovsky